Feature/api v3 updates

[fivetran-catfritz]

PR Overview

This PR will address the following Issue/Feature: #9

This PR will result in the following new package version:

0.2.0 - Columns deleted

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

• When I was updating docs I realized my src_amazon_ads.yml didn't align with the staging and nor did the seeds. I updated them to be in line with what the staging models actually utilize.
• The rest of the changes stem from the connector release notes:

Features

• Added a new column, native_language_locale, to the keyword_history staging tables.
• Made the following changes to the campaign_history table:
  • Added three new columns, budget, budget_type, and effective_budget
  • Removed the campaign_type, daily_budget, placement, and premium_bid_adjustment columns
• Updated documentation with descriptions of the new columns.

Under the Hood

• get_*_column macros now set the data type of the id column from INTEGER to STRING.
• Updated testing seed data to reflect the column changes.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

• confirm columns come through. See ticket for dataset used.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

[fivetran-joemarkiewicz]

@fivetran-catfritz thanks for working though this PR! This is looking great, I do have a few comments in my review below that should be addressed before approving.

Additionally, in parallel to the transform PR, I wanted to highlight that I would recommend casting the id fields in the _report models to be of type string. This way you will not need to do the in join casting within the transformation models. I would prefer we do this casting in the staging models. Additionally, this ensures we are keeping the models consistent across. Even though it is strange we changed the datatype of the id for the history tables, but not the report in the API upgrade 🤔. Let me know if you have any concerns with this recommendation.

Thanks!

[fivetran-joemarkiewicz]

This is a breaking change. Would you be able to include this in the breaking section so customers are immediately aware of the change.

[fivetran-catfritz]

updated

[fivetran-joemarkiewicz]

I never really understand why GitHub highlights multiple lines in the review when I only selected one haha In my review I only meant this comment to pertain to line 9 in the above code block. The removal of fields are the breaking changes, but the others are more features and align with you previous CHANGELOG entry.

Would you be able to only include the removed fields as the breaking change to make it very apparent to users what fields are being removed. The others may then be listed as Feature updates as you had previously. Apologies for the confusion.

[fivetran-catfritz]

Oh got it! I have updated.

[fivetran-catfritz]

Thanks for the suggestions! I made those and also updated the casting of ids to strings in the staging models.

[fivetran-joemarkiewicz]

Please see my one small final comment here to apply before this is good to go.

Once that is applied this is all ready!! Thanks for working through these changes 😄