feature/api-v3-updates

[fivetran-catfritz]

PR Overview

This PR will address the following Issue/Feature: fivetran/dbt_amazon_ads_source#9

This PR will result in the following new package version:

• 0.2.0 - source is breaking

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

• The datatypes of some id columns were changed to string. I updated the joins to cast everything as string. It was a bit of a nuclear solution, but there was a lack of consistency plus I wanted to avoid any future column data type changes.

🎉 Features

• Updated documentation to reference changes in the source package.

🚘 Under the Hood

• Update casts on joins to bridge the gap between ID types changed to STRING and IDs that remained type INTEGER.
• Updated testing seed data to reflect the source seed changes.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

• Changed columns were not included in this package
• Models run with no error on actual data.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

[fivetran-joemarkiewicz]

@fivetran-catfritz thanks for working through these updates. I do have a few inline comments below that should be addressed before approving. Primarily, I would request we remove the in join casting in place of performing those within the staging models. Let me know if you want to discuss this in more detail. Thanks!

[fivetran-joemarkiewicz]

Reminder to update before merge and release.

[fivetran-catfritz]

This is ready for re-review.

[fivetran-joemarkiewicz]

@fivetran-catfritz thanks so much for working through these updates! I just have two small comments that I would like your eyes on. Once you take a look and make any minor updates, this is good to go!

As these are very minor comments, I am happy to approve this PR!