Skip to content

Ignore error from close first window after startup. #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Ignore error from close first window after startup. #175

merged 1 commit into from
Jun 3, 2016

Conversation

mortonfox
Copy link
Contributor

The problem is in iTerm2 3.0.0, when Preferences/General/Startup is set
to "Don't Open Any Windows", it does not open a window when it starts
up. So "close first window" fails with an error. To handle this
scenario, we can simply wrap this statement in try / end try.

The problem is in iTerm2 3.0.0, when Preferences/General/Startup is set
to "Don't Open Any Windows", it does not open a window when it starts
up. So "close first window" fails with an error. To handle this
scenario, we can simply wrap this statement in try / end try.
@thshdw
Copy link
Collaborator

thshdw commented Jun 3, 2016

Hi @mortonfox good catch. This is not specific to v3 however. Don't Open Any Windows was also in the 2.9 nightlies as far back as Build 2.9.20140715-nightly from 2014. So this issue has been around for awhile.

Thanks for taking the time to open a pull 👍

@thshdw thshdw merged commit bfd2b0c into fitztrev:master Jun 3, 2016
@thshdw thshdw mentioned this pull request Jun 5, 2016
@thshdw thshdw mentioned this pull request Jul 24, 2016
thshdw pushed a commit that referenced this pull request Jul 24, 2016
Fixes for 1.2.7
* Corrected an issue where commas in commands would not be parsed. #173

* Changed the directive names for iTerm_version. Valid names are
legacy, stable, nightly. #181

* Contains new icons by @pluwen #141

* Contains an apple script fix by @mortonfox where an iTerm setting would prevent scripts from running #175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants