instead hard code by variable in error message #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soamvasani
reviewed
Jun 8, 2018
controller/packageApi.go
Outdated
| @@ -64,12 +66,14 @@ func (a *API) PackageApiCreate(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| // Ensure size limits | |||
| if len(f.Spec.Source.Literal) > int(fission.ArchiveLiteralSizeLimit) { | |||
| err := fission.MakeError(fission.ErrorInvalidArgument, "Package literal larger than 256K") | |||
| err := fission.MakeError(fission.ErrorInvalidArgument, | |||
| fmt.Sprintf("Package literal larger than 0x%s", strconv.FormatInt(fission.ArchiveLiteralSizeLimit, 16))) | |||
There was a problem hiding this comment.
The error is for humans, plain old decimal is probably better. Also, please include units (bytes/kb/etc).
|
@soamvasani I introduced the package |
|
LGTM. |
This introduces human size package, to indicate number by human readable string.
…izeLimit value This prints error message to indicate `ArchiveLiteralSizeLimit` value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArchiveLiteralSizeLimithas constant value. When encountering the package error here, we should warn the exactArchiveLiteralSizeLimitvalue, but not256KBhard code.This change is