Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use time.Since instead of time.Now().Sub #449

Merged
merged 1 commit into from
Jan 24, 2018
Merged

use time.Since instead of time.Now().Sub #449

merged 1 commit into from
Jan 24, 2018

Conversation

wgliang
Copy link
Contributor

@wgliang wgliang commented Jan 17, 2018 •
edited by soamvasani
Loading

use time.Since instead of time.Now().Sub

This change is Reviewable

@life1347
Copy link
Member

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

@soamvasani soamvasani changed the title Optimize code use time.Since instead of time.Now().Sub Jan 23, 2018
@erwinvaneyk
Copy link
Member

LGTM 👍

@life1347
Copy link
Member

Hi @wgliang, thanks for your PR. I am going to merge it.

@life1347 life1347 merged commit b578819 into fission:master Jan 24, 2018
@life1347 life1347 mentioned this pull request Jan 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wgliang @life1347 @erwinvaneyk