Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poolmanager terminates running function pod periodically #1435

Merged
merged 5 commits into from
Nov 25, 2019

Conversation

life1347
Copy link
Member

@life1347 life1347 commented Nov 25, 2019

The pool manager keeps terminating function pod periodically even there are
traffic to the function. The root cause is that executor, poolmgr, newdeploy
manage their own functionServiceCache separately. And when router taps a
function, executor updates the access time of the function service entry in its
own cache without notifying executor types to do the update as well. Hence,
the access time of function service entry in poolmanager cache never gets updated.
Due to the access time never gets updated, the idle pod reaper in poolmanager
then thinks the function pod is in idle state and recycle it.

This PR removes the cache in executor itself, and when router tries to tap a function,
executor will call executor type to tap the function and update access time.


This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #1435 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   31.76%   31.76%           
=======================================
  Files          69       69           
  Lines        5562     5562           
=======================================
  Hits         1767     1767           
  Misses       3561     3561           
  Partials      234      234
Impacted Files Coverage Δ
pkg/fission-cli/cmd/function/update.go 0% <0%> (ø) ⬆️
pkg/fission-cli/cmd/function/create.go 20.83% <88.88%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2fe08...7ebc1e2. Read the comment docs.

@life1347 life1347 merged commit 51b264e into master Nov 25, 2019
@life1347 life1347 deleted the fix-poolmgr-spwaning branch November 25, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant