Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move route creation to function #1362

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Move route creation to function #1362

merged 2 commits into from
Oct 29, 2019

Conversation

life1347
Copy link
Member

@life1347 life1347 commented Oct 29, 2019

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #1362 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
+ Coverage   31.62%   31.64%   +0.02%     
==========================================
  Files          68       68              
  Lines        6441     6443       +2     
==========================================
+ Hits         2037     2039       +2     
  Misses       4167     4167              
  Partials      237      237
Impacted Files Coverage Δ
pkg/controller/api.go 69.28% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20dc9a...03fd692. Read the comment docs.

@life1347 life1347 merged commit a151f89 into master Oct 29, 2019
@life1347 life1347 deleted the move-route-to-function branch October 29, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant