Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace router svcAddrUpdateLocks with new throttler package for code readability&reusability #1047

Merged
merged 7 commits into from
Jan 16, 2019

Conversation

life1347
Copy link
Member

@life1347 life1347 commented Jan 7, 2019

Address followup comments in #991 and add new throttler package.

This change is Reviewable

@life1347 life1347 force-pushed the refactor-roundtrip-followup-comments branch 2 times, most recently from ef47068 to c9d30d5 Compare January 7, 2019 08:44
@vishal-biyani vishal-biyani added this to the 1.0 milestone Jan 9, 2019
Copy link
Member

@soamvasani soamvasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, LGTM!
We could change the executor to use this package too, at some point.

@@ -482,24 +491,32 @@ func (fh *functionHandler) getServiceEntry() (serviceUrl *url.URL, serviceUrlFro
// To prevent multiple update requests will be sent to executor and make executor overloaded,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update comment since there is no visible goroutine here?

timeExpiry time.Duration
}

// Throttler is a simple throttling mechanism implementation provides
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... is a simple throttling mechanism that provides the ability to...

@life1347 life1347 force-pushed the refactor-roundtrip-followup-comments branch from 3b2784c to 18eaa8b Compare January 14, 2019 11:47
@life1347 life1347 changed the title Refactor roundtrip followup comments Replace router svcAddrUpdateLocks with new throttler package for code readability&reusability Jan 14, 2019
@life1347 life1347 force-pushed the refactor-roundtrip-followup-comments branch 2 times, most recently from e06a494 to 35b9be0 Compare January 15, 2019 01:42
@life1347 life1347 force-pushed the refactor-roundtrip-followup-comments branch from 7264164 to f828a31 Compare January 16, 2019 03:51
@life1347 life1347 merged commit 273c6c0 into master Jan 16, 2019
@life1347 life1347 deleted the refactor-roundtrip-followup-comments branch January 16, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants