Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Do not pretend to be a GNU/Linux #114

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Do not pretend to be a GNU/Linux #114

merged 1 commit into from
Aug 5, 2019

Conversation

alex
Copy link
Member

@alex alex commented Aug 5, 2019

@alex alex requested a review from geofft August 5, 2019 01:48
@alex alex merged commit 28f3ea7 into master Aug 5, 2019
@alex alex deleted the alex-patch-1 branch August 5, 2019 02:05
@geofft
Copy link
Collaborator

geofft commented Aug 5, 2019

FWIW, torvalds/linux@5f074f3 (v5.1) adds a bcmp that's implemented as memcmp, saying specifically that this LLVM change broke upstream clang targets. So,

  1. Should we put this back once we can assume 5.1+?
  2. Do the upstream kernel clang targets use unknown-linux-gnu and if so should we do the same?

@alex
Copy link
Member Author

alex commented Aug 5, 2019

Excellent question, don't know!

@geofft
Copy link
Collaborator

geofft commented Aug 5, 2019

Poking around a bit more, https://github.com/ClangBuiltLinux/linux/wiki/Steps-for-compiling-the-kernel-with-Clang It seems the Makefile doesn't do anything super conditional, they're just using clang as a cc.

Should we suggest that the upstream clang build cross-compile to foo-elf instead of compiling for the native platform / foo-unknown-linux-gnu?

@alex
Copy link
Member Author

alex commented Aug 5, 2019 via email

@geofft geofft mentioned this pull request Aug 28, 2019
@nickdesaulniers
Copy link

#147 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants