Skip to content

write a log record when tree import succeeded or failed - #5407

Open
BertKoor wants to merge 1 commit into
fisharebest:mainfrom
BertKoor:issue5379_log_import
Open

write a log record when tree import succeeded or failed#5407
BertKoor wants to merge 1 commit into
fisharebest:mainfrom
BertKoor:issue5379_log_import

Conversation

@BertKoor

Copy link
Copy Markdown
Contributor

this fixes issue #5379

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.77%. Comparing base (a64cc99) to head (3b3b9cd).
⚠️ Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
app/Http/RequestHandlers/GedcomLoad.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5407      +/-   ##
============================================
+ Coverage     35.49%   35.77%   +0.27%     
+ Complexity    11211    11206       -5     
============================================
  Files          1166     1181      +15     
  Lines         48077    48026      -51     
============================================
+ Hits          17065    17180     +115     
+ Misses        31012    30846     -166     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddrury

ddrury commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Wouldn't the edit log be a better bet than the config log

@BertKoor

Copy link
Copy Markdown
Contributor Author

Wouldn't the edit log be a better bet than the config log

Good question! My consideration to determine which to use, is that an editor cannot do an import. It can only be done by an administrator via the control panel. And thus the config section is imho a better fit.

I did change the log records written when an import fails to the error type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants