Demo - [Guidelines] - log user data & public API route

[wvl94]

💡 PR Summary generated by FirstMate

Overview: Implemented user data logging and added a public API route for user data retrieval.

Changes:
GitHub Actions Workflow:

• Updated .github/workflows/firstmate.yaml to run pnpm test after package installation for CI.

New API Route:

• Added /user-data/:id route in exampleRouter.js to retrieve user data.

Service Enhancements:

• Introduced getUserData method in ExampleService to log user data.
• Created NewService class for additional data retrieval functionalities.

TLDR: Focus on the new /user-data/:id route and the logging functionality in ExampleService.

_{^{Generated by FirstMate and automatically updated on every commit.}}

[firstmate]

PR Review

⚠️ It seems that you can still improve the quality of your PR:

    ❌ Testing: Missing unit tests for new service functions in newService.js.
    ❌ Security: Missing permission middleware on /user-data/:id route.

_{^{Generated by Firstmate to make sure you can focus on coding new features.}}

[firstmate]

The new service functions in newService.js should have corresponding unit tests to ensure functionality and catch potential issues early. Please implement unit tests for these functions in the test folder. Based on the existing implemented unit test in test/test-newService.js, you could implement the new unit tests as follows:

import NewService from '../services/newService.js';

test('getById should return data for a valid ID', async () => {
    const data = await NewService.getById(1);
    expect(data).toBeDefined();
});

(Based on guideline 'Service functions should have unit tests')

[firstmate]

The new route '/user-data/:id' is missing the grantAccessByPermissionMiddleware for permission checks. You should update it to include this middleware as follows:

+ router.route("/user-data/:id").get(grantAccessByPermissionMiddleware([API_PERMISSIONS.PUBLIC_ENDPOINT]), exampleController.getById)

This ensures that proper access control is enforced for this endpoint.

(Based on guideline 'Check permissions with middleware')