Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecuadorian translation #70529

Merged

Conversation

diegotony
Copy link
Contributor

No description provided.

@diegotony
Copy link
Contributor Author

@fakiolinho @stefanoszisidis @EuripidisK, @adreaskar, @nextdoorpanda

I have created this PR to help with the translation, could you review it?

@adreaskar
Copy link
Contributor

adreaskar commented Aug 8, 2023

Hello @diegotony ! Sorry but the people you have tagged are Greek reviewers. You can take a look at this list of reviewers to find someone for a Spanish translation review 😃

@diegotony
Copy link
Contributor Author

@yirini @aaossa

I have created this PR to help with the translation, could you review it?

@yirini
Copy link

yirini commented Aug 12, 2023

Hi @diegotony. I read your PR and everything looks fine.

@diegotony
Copy link
Contributor Author

Thanks @yirini, so, who do I ask to help me merge?

@aaossa
Copy link

aaossa commented Aug 16, 2023

Why is this translation necessary? Is it not enough with the spanish version already present? There is one from Spain and another from Mexico (generally used for latam). Why is this necessary?

@yirini
Copy link

yirini commented Aug 16, 2023

@aaossa And why not? I think that @diegotony just wanted to contribute to the open source space and this is a always good, even if there's other translations already. A welcoming attitude it's always rewarding.

@yirini
Copy link

yirini commented Aug 16, 2023

Thanks @yirini, so, who do I ask to help me merge?

@yirini
Copy link

yirini commented Aug 16, 2023

@diegotony if you follow the last step ''Now submit the pull request'' on this link: https://github.com/firstcontributions/first-contributions/tree/main, you will be able to marge it.

@aaossa
Copy link

aaossa commented Aug 16, 2023

What I mean is that there's no "Ecuadorian spanish", at least is not a common classification, but Ok I guess

Copy link
Contributor

@Esh07 Esh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @diegotony, thank you so much for your PR on the translation. We really appreciate it.

Hi @diegotony. I read your PR and everything looks fine.

Hey @yirini, thank you for taking the time to review the changes and for your valuable contribution.

I will mark this as approved since @yirini agrees with the changes. @yirini, you can mark this as approved so the maintainer can merge it.

Hey @Roshanjossey, this PR is ready to be merged.

Cheers,
Esh

@diegotony
Copy link
Contributor Author

I will mark this as approved since @yirini agrees with the changes. @yirini, yo

Hi @Esh07 I dont have permisions to merge

@Esh07
Copy link
Contributor

Esh07 commented Aug 22, 2023

I will mark this as approved since @yirini agrees with the changes. @yirini, yo

Hi @Esh07 I dont have permisions to merge

Only the maintainer can merge the PR. I already tag @Roshanjossey.

Cheers
Esh

@Roshanjossey
Copy link
Member

Thank you for the changes @diegotony

Thank you for reviewing @yirini

Thank you for handling this @Esh07

Merging

@Roshanjossey Roshanjossey merged commit 4f626e5 into firstcontributions:main Aug 23, 2023
@Roshanjossey
Copy link
Member

@aaossa, I agree with you. if Ecuadorians understand Readme.es.md. We don't need a separate translation readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants