-
-
Notifications
You must be signed in to change notification settings - Fork 83.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ecuadorian translation #70529
Add Ecuadorian translation #70529
Conversation
@fakiolinho @stefanoszisidis @EuripidisK, @adreaskar, @nextdoorpanda I have created this PR to help with the translation, could you review it? |
Hello @diegotony ! Sorry but the people you have tagged are Greek reviewers. You can take a look at this list of reviewers to find someone for a Spanish translation review 😃 |
Hi @diegotony. I read your PR and everything looks fine. |
Thanks @yirini, so, who do I ask to help me merge? |
Why is this translation necessary? Is it not enough with the spanish version already present? There is one from Spain and another from Mexico (generally used for latam). Why is this necessary? |
@aaossa And why not? I think that @diegotony just wanted to contribute to the open source space and this is a always good, even if there's other translations already. A welcoming attitude it's always rewarding. |
|
@diegotony if you follow the last step ''Now submit the pull request'' on this link: https://github.com/firstcontributions/first-contributions/tree/main, you will be able to marge it. |
What I mean is that there's no "Ecuadorian spanish", at least is not a common classification, but Ok I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @diegotony, thank you so much for your PR on the translation. We really appreciate it.
Hi @diegotony. I read your PR and everything looks fine.
Hey @yirini, thank you for taking the time to review the changes and for your valuable contribution.
I will mark this as approved since @yirini agrees with the changes. @yirini, you can mark this as approved so the maintainer can merge it.
Hey @Roshanjossey, this PR is ready to be merged.
Cheers,
Esh
Only the maintainer can merge the PR. I already tag @Roshanjossey. Cheers |
Thank you for the changes @diegotony Thank you for reviewing @yirini Thank you for handling this @Esh07 Merging |
@aaossa, I agree with you. if Ecuadorians understand Readme.es.md. We don't need a separate translation readme. |
No description provided.