Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jemal Ahmedov to Contributors list #581

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Add Jemal Ahmedov to Contributors list #581

merged 1 commit into from
Oct 1, 2017

Conversation

jimjja
Copy link

@jimjja jimjja commented Oct 1, 2017

No description provided.

@Roshanjossey
Copy link
Member

@jimjja, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

@Roshanjossey Roshanjossey merged commit 024fab9 into firstcontributions:master Oct 1, 2017
@jimjja
Copy link
Author

jimjja commented Oct 1, 2017

Hello, @Roshanjossey, I am a big fan of the open source community and Git as I am using it at work as well but I have never contributed to other projects, outside work and my own.

The tutorial was very clear of what to do and how to do it. I have read that other people had issues when trying to sync with the main repo as they were deleting their branches. I saw that the Next Steps link includes this information which I believe if clarified better it might not confuse people (e.g. Additional Steps instead of Next steps). I am more than happy to help you evolve the project.
One thing I don't understand is the following:
If a person starts working on an issue, what happens when other people start doing it as well because there is no clarification anywhere (at least I cannot see it) that someone is already working on it. Following this scenario are you checking the different pull requests and decide what will suit the best or you are just picking the first one done if it suits the purpose.

@Roshanjossey
Copy link
Member

@jimjja, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

@Roshanjossey
Copy link
Member

Roshanjossey commented Oct 1, 2017

To answer your questions

I believe if clarified better it might not confuse people (e.g. Additional Steps instead of Next steps)

Yes, it makes more sense to change this text to Additional steps or additional material. I'd also love to have a readme.md in that directory so that we can give links to file names with description.

Do you wanna take this up? I'll create an issue

@Roshanjossey
Copy link
Member

If a person starts working on an issue, what happens when other people start doing it as well because there is no clarification anywhere

I ask contributors to comment on issues saying they wanna take up an issue before starting working.
It's listed in steps #129

scenario are you checking the different pull requests and decide what will suit the best or you are just picking the first one done

I've never had a situation where I had multiple pull requests solving same issue. I'd try to avoid this and make most of my contributors' time. Another improvement I can make to the flow is to add a WIP flag when somebody commits to an issue.

@jimjja
Copy link
Author

jimjja commented Oct 1, 2017

The WIP tag is a good solution. This way you will directly see that it is work in progress even without opening the issue

@jimjja
Copy link
Author

jimjja commented Oct 1, 2017

@Roshanjossey
Copy link
Member

@jimjja, sounds good. could we also have a brief description of what those steps do and why do it? Just the title might not convey much

@jimjja
Copy link
Author

jimjja commented Oct 1, 2017

Yeah sure, I will create PR for this bit and then work on the additional information

@jimjja
Copy link
Author

jimjja commented Oct 1, 2017

Something like this?

Keeping your fork synced with this repository

This document provides information about how to keep your forked repository up-to-date with the base repository.

Follow these steps if your fork doesn't have any changes in parent repository.

@Roshanjossey
Copy link
Member

@jimjja: This is awesome mate. Good thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants