Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[other languages] link deleted from all language and bn link fixed. closes #54383 #54416

Merged
merged 3 commits into from
Sep 25, 2022
Merged

[other languages] link deleted from all language and bn link fixed. closes #54383 #54416

merged 3 commits into from
Sep 25, 2022

Conversation

asifurrahaman754
Copy link
Contributor

No description provided.

@asifurrahaman754
Copy link
Contributor Author

@Roshanjossey will you review my pr?

@@ -114,7 +113,7 @@ git push origin -u <your-new-branch-name>

এখন আপনি অন্যান্য প্রজেক্টগুলোতেও অবদান রাখতে পারেন। আপনার সুবিধার্থে আমরা সহজ সমস্যা সম্বলিত প্রজেক্টগুলোর একটি তালিকা তৈরি করেছি। ওয়েব অ্যাপে [প্রজেক্টগুলোর তালিকা](https://roshanjossey.github.io/first-contributions/#project-list) দেখুন।

### [ অতিরিক্ত উপাদানসমূহ ](../additional-material/git_workflow_senarios/additional-material.md)
### [ অতিরিক্ত উপাদানসমূহ ](https://github.com/asifurrahaman754/first-contributions/blob/main/additional-material/git_workflow_scenarios/additional-material.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### [ অতিরিক্ত উপাদানসমূহ ](https://github.com/asifurrahaman754/first-contributions/blob/main/additional-material/git_workflow_scenarios/additional-material.md)
### [ অতিরিক্ত উপাদানসমূহ ](../additional-material/git_workflow_scenarios/additional-material.md)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roshanjossey if i make the link like ../, then the link does not work, that's why i gave the absolute link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asifurrahaman754, relative URL will work. Trust me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roshanjossey Roshanjossey merged commit cc62547 into firstcontributions:main Sep 25, 2022
@Roshanjossey
Copy link
Member

Thank you for making this change 🖖 ✨

@asifurrahaman754 asifurrahaman754 deleted the asifur-changes branch September 25, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants