Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double mint fix #744

Merged
merged 6 commits into from
Oct 23, 2019
Merged

Double mint fix #744

merged 6 commits into from
Oct 23, 2019

Conversation

levonpetrosyan93
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 commented Oct 20, 2019 •
edited
Loading

Fix for #743

psolstice
psolstice requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@psolstice psolstice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a unit test for it

@levonpetrosyan93
Copy link
Contributor Author

I think we need a unit test for it

Yes, Thank you, will add.

ultimaweapon
ultimaweapon suggested changes Oct 21, 2019
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/sigma.cpp Outdated Show resolved Hide resolved
riordant
riordant approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@riordant riordant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenyap reubenyap merged commit b8411b8 into master Oct 23, 2019
@levonpetrosyan93 levonpetrosyan93 deleted the double_mint_fix branch October 23, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psolstice psolstice psolstice approved these changes

@riordant riordant riordant approved these changes

@ultimaweapon ultimaweapon Awaiting requested review from ultimaweapon

Assignees
No one assigned
Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@levonpetrosyan93 @ultimaweapon @riordant @psolstice @reubenyap @qashban4