Fixed the unspent index for remints of 50 XZC #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riordant
suggested changes
Oct 3, 2019
src/txdb.cpp
Outdated
| error("A Zerocoin to Sigma remint tx shoud have just 1 input"); | ||
| return; | ||
| } | ||
| handleRemint(tx.vin[0], 0, tx.GetHash(), height, txNumber, remintValue, addressIndex, addressUnspentIndex, spentIndex); |
There was a problem hiding this comment.
The second parameter inputNo to handleRemint is no longer necessary and should be removed. This will also imply by the code that a remint can only have one input.
riordant
previously approved these changes
Oct 3, 2019
psolstice
requested changes
Oct 4, 2019
psolstice
approved these changes
Oct 7, 2019
riordant
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Fixes an issue with calculating balance of remint transactions in case of 50XZC remints, which produced 2 outputs of 25 XZC Sigma mints.
Code changes brief
Now all remint outputs are summed up and used as the amount for the input.