Add RPC function to regenerate mint pool if incorrect indexes used #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-bezrukov
suggested changes
Aug 1, 2019
src/hdmint/wallet.cpp
Outdated
| { | ||
| bool fFound = false; | ||
| for(auto serialPubcoinPair : serialPubcoinPairs){ | ||
| GroupElement pubcoin = serialPubcoinPair.second; |
There was a problem hiding this comment.
Could you clarify what you mean here?
There was a problem hiding this comment.
pubcoin is a copy now. I think making it GroupElement const & pubcoin = serialPubcoinPair.second will be better performance-wise.
There was a problem hiding this comment.
I think it can be like this const GroupElement& pubcoin.
There was a problem hiding this comment.
Will be more readable if we keep this line, only make it const reference.
a-bezrukov
approved these changes
Aug 1, 2019
src/hdmint/wallet.cpp
Outdated
| { | ||
| bool fFound = false; | ||
| for(auto serialPubcoinPair : serialPubcoinPairs){ | ||
| GroupElement pubcoin = serialPubcoinPair.second; |
There was a problem hiding this comment.
pubcoin is a copy now. I think making it GroupElement const & pubcoin = serialPubcoinPair.second will be better performance-wise.
levonpetrosyan93
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
FIxes an issue where wallets, generated with HD mint prior to 0.13.8.2, have mints that are always stuck in "pending" on the Sigma page. This is due to incorrect indexes being generated for the mint pool database functions in the 0.13.8.1 release. The fix is simply to regenerate the mint pool from the known values, and add with the correct indexes.
Also adds increased logging level generally for HD mint code.
Code changes brief
regeneratemintpoolRegenerateMintPoolEntryto return a uint256 pair -<hashPubcoin, hashSerial>