Export View Keys #1543
Export View Keys #1543
Conversation
WalkthroughThis change set integrates a new feature for exporting the Spark view key. The build configuration was updated to include additional UI, MOC, header, and source files related to the new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BitcoinGUI
participant WalletFrame
participant WalletView
participant ExportViewKeyDialog
participant WalletBackend
User->>BitcoinGUI: Click "Export View Key" in menu
BitcoinGUI->>WalletFrame: Trigger exportViewKey()
WalletFrame->>WalletView: Invoke exportViewKey()
WalletView->>WalletBackend: Get Spark view key (GetSparkViewKeyStr)
WalletBackend-->>WalletView: Return key string
WalletView->>ExportViewKeyDialog: Create dialog with key
ExportViewKeyDialog-->>User: Display view key
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (10)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (7)
src/qt/forms/exportviewkeydialog.ui (1)
1-86: UI design looks good but consider adding a warning labelThe dialog UI is well structured with proper layout components and a selectable text field for the view key. The window size, title, and button configuration are appropriate for this functionality.
Consider adding a warning label to inform users about the sensitivity of the view key and potential security implications of exporting it. This would help users understand the implications of this action.
+ <item> + <widget class="QLabel" name="infoLabel"> + <property name="text"> + <string>Warning: Keep this key private. Anyone with access to this key can view your Spark transactions but cannot spend your funds.</string> + </property> + <property name="wordWrap"> + <bool>true</bool> + </property> + <property name="textFormat"> + <enum>Qt::RichText</enum> + </property> + </widget> + </item>src/qt/bitcoingui.h (1)
8-8: Consider using forward declaration instead of include.Since you're only using
ExportViewKeyDialogas a pointer type in this header file, you could forward declare the class instead of including the full header. This would reduce compilation dependencies and potentially improve build times.-#include "exportviewkeydialog.h" +// Forward declarations +class ExportViewKeyDialog;Then include the actual header in the .cpp file where you implement the related functionality.
src/qt/exportviewkeydialog.h (3)
1-2: Inconsistent include guard naming.The include guard name doesn't match the class name. For consistency, use
EXPORTVIEWKEYDIALOG_Hinstead ofVIEWKEYDIALOG_H.-#ifndef VIEWKEYDIALOG_H -#define VIEWKEYDIALOG_H +#ifndef EXPORTVIEWKEYDIALOG_H +#define EXPORTVIEWKEYDIALOG_H
12-22: Consider adding signals/slots for user interaction.The dialog is functionally correct, but it could benefit from having signals and slots defined for handling user interactions like copying the view key to clipboard or handling the close action. This would make the dialog more interactive and user-friendly.
Example addition:
private slots: void copyToClipboard();
25-25: Include guard closing comment.For better readability, consider adding a comment at the end of the include guard to indicate which guard it's closing.
-#endif +#endif // EXPORTVIEWKEYDIALOG_Hsrc/wallet/wallet.h (1)
1171-1173: Consider marking methods as const.Since these methods are likely just retrieving data without modifying the wallet state, consider marking them as
constto indicate they don't modify the object's state and to allow calling them on const wallet references/pointers.-spark::FullViewKey GetSparkViewKey(); -std::string GetSparkViewKeyStr(); +spark::FullViewKey GetSparkViewKey() const; +std::string GetSparkViewKeyStr() const;src/wallet/wallet.cpp (1)
8869-8885: Well-implemented method for exporting the view key as a mnemonic.The function properly serializes the view key and converts it to a mnemonic format. Good use of assertions to validate the data integrity during the conversion process.
A few minor suggestions:
- Consider adding error handling if the mnemonic conversion fails rather than relying on assertions
- Add a comment indicating that the return value is sensitive information
std::string CWallet::GetSparkViewKeyStr() { spark::FullViewKey key = GetSparkViewKey(); int size = GetSerializeSize(key, SER_NETWORK, PROTOCOL_VERSION); std::ostringstream keydata; ::Serialize(keydata, key); std::string keydata_s = keydata.str(); assert(keydata_s.size() % 4 == 0); SecureVector seckeydata(keydata_s.begin(), keydata_s.end()); + // Convert serialized key to mnemonic format - treat as sensitive information SecureString mnemonicsecstr = Mnemonic::mnemonic_from_data(seckeydata, seckeydata.size()); std::string mnemonicstr(mnemonicsecstr.begin(), mnemonicsecstr.end()); assert(!mnemonicstr.empty()); return mnemonicstr; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/Makefile.qt.include(5 hunks)src/qt/bitcoingui.cpp(6 hunks)src/qt/bitcoingui.h(2 hunks)src/qt/exportviewkeydialog.cpp(1 hunks)src/qt/exportviewkeydialog.h(1 hunks)src/qt/forms/exportviewkeydialog.ui(1 hunks)src/qt/walletframe.cpp(1 hunks)src/qt/walletframe.h(1 hunks)src/qt/walletview.cpp(2 hunks)src/qt/walletview.h(1 hunks)src/wallet/bip39.cpp(2 hunks)src/wallet/rpcdump.cpp(2 hunks)src/wallet/rpcwallet.cpp(2 hunks)src/wallet/wallet.cpp(4 hunks)src/wallet/wallet.h(2 hunks)
🔇 Additional comments (25)
src/qt/walletframe.h (1)
95-96: LGTM! Good method documentation and placement.The method declaration for exporting the Spark View Key is well-documented and correctly placed in the public Q_SLOTS section, following the existing pattern of similar functionality in the class.
src/qt/walletframe.cpp (1)
191-196: LGTM! Implementation follows established patterns.The implementation correctly follows the pattern used by other similar methods in this class (like
changePassphrase()andbackupWallet()). It properly retrieves the current wallet view and checks for validity before proceeding, which is good defensive programming.src/qt/walletview.h (1)
131-132: LGTM! Well-documented and properly placed.The method declaration is clearly documented and correctly placed in the public Q_SLOTS section, maintaining consistency with the class's existing organization pattern.
src/qt/walletview.cpp (2)
13-13: LGTM! Appropriate include for new dialog.The include for the new
exportviewkeydialog.hheader file is correctly added to support the new functionality.
391-395: LGTM! Implementation is correct and concise.The implementation properly creates an instance of
ExportViewKeyDialog, passing it the current wallet's Spark view key string and then executing the dialog. This follows the pattern used by other dialog-based features in the codebase.src/qt/forms/exportviewkeydialog.ui (1)
20-36: Key label has good user experience propertiesThe text label is properly configured with mouse selection enabled, which allows users to easily copy the view key, and word wrap to handle potentially long keys.
src/qt/bitcoingui.cpp (5)
119-119: Properly initialized action in constructor initializer listThe new
exportViewKeyActionis correctly initialized to null in the constructor's initializer list, following the pattern used for other actions.
412-413: Action creation well implementedThe
exportViewKeyActionis properly created with an appropriate descriptive name and helpful status tip that explains its purpose clearly.
453-453: Action connection correctly implementedThe action is properly connected to the
walletFrame->exportViewKey()slot following the pattern used for other wallet actions.
486-486: Menu placement is appropriateThe new action is correctly added to the File menu alongside other related wallet actions like signing and verifying messages.
659-659: Action enabled/disabled based on wallet stateThe
exportViewKeyActionis properly included in thesetWalletActionsEnabledmethod, ensuring it will be enabled or disabled appropriately based on the wallet's state.src/wallet/bip39.cpp (1)
44-46:✅ Verification successful
Relaxed input length validation in mnemonic_from_data function
The condition for validating the input length has been modified to only check if
lenis divisible by 4, removing the previous constraints that required the length to be between 16 and 32.This change could have security implications if it allows for inputs that were previously considered invalid. Verify that:
- The Spark view key requires this relaxed validation
- The function still produces secure mnemonics with longer inputs
- Other code using this function is aware of and can handle the new behavior
🏁 Script executed:
#!/bin/bash # Check where mnemonic_from_data is used in the codebase echo "Searching for mnemonic_from_data usage:" rg "mnemonic_from_data" --type cpp # Check the size of Spark view key that will be passed to this function echo "Looking for Spark view key size references:" rg "sparkViewKey|Spark.*?view.*?key.*?size" --type cppLength of output: 1154
Security Validation Confirmation: Update Approved
After verification, the following was determined:
- Usage Context: The function
mnemonic_from_datais primarily invoked from controlled call sites (e.g., insrc/wallet/bip39.cpp,src/wallet/wallet.cpp, and tests insrc/wallet/test/mnemonic_tests.cpp) where the length value is computed (commonly asstrength / 8) ensuring it meets expected inputs.- Spark View Key: References to the Spark view key appear exclusively in QT components (e.g.,
ExportViewKeyDialoginsrc/qt/exportviewkeydialog.cpp/h), and are not coupled with the mnemonic conversion logic.- Security Outcome: The existing tests confirm that even with inputs longer than the historically constrained range, secure mnemonics are produced as long as the input length is a multiple of 4.
No additional security implications are found, and all code using this function seems aware of and capable of handling the new behavior.
src/qt/exportviewkeydialog.cpp (2)
1-9: Dialog implementation is simple and correctThe dialog implementation effectively sets up the UI and displays the Spark view key. The constructor properly initializes the UI and sets the text in the key label from the provided string.
11-13: Destructor correctly cleans up resourcesThe destructor properly deletes the UI object to prevent memory leaks, following Qt best practices.
src/qt/bitcoingui.h (1)
119-119: LGTM: New action for exporting view keys.The addition of this action pointer is appropriate for implementing the new view key export functionality in the GUI.
src/qt/exportviewkeydialog.h (1)
4-6: LGTM: Appropriate Qt includes.These includes are appropriate for a Qt dialog that may use message boxes and buttons.
src/wallet/wallet.h (1)
12-12: LGTM: Required include for Spark view key functionality.This include is necessary to support the new methods for accessing Spark view keys.
src/wallet/rpcwallet.cpp (2)
4704-4705: Appropriate external function declaration for the new Spark view key functionality.The declaration properly follows the same pattern as other similar key export functions.
5725-5726: Correctly registered the new dumpsparkviewkey RPC command in the commands array.The command is properly configured in the "wallet" category with appropriate safety parameters. The command doesn't require any arguments as indicated by the empty parameter array, which is consistent with the PR objective of enabling Spark view key export via RPC.
src/wallet/rpcdump.cpp (1)
7-7: Appropriate include for Spark functionality.The addition of the
libspark/keys.hinclude is necessary for the new Spark view key functionality.src/wallet/wallet.cpp (1)
8860-8867: Functionality for retrieving Spark view key looks good.This new method retrieves the Spark view key from the wallet database with appropriate locking, following the wallet's standard pattern for accessing sensitive data.
src/Makefile.qt.include (4)
98-98: LGTM - UI file addition for view key export dialogThe addition of the export view key dialog UI file to the QT_FORMS_UI list is appropriate for the feature being implemented.
143-143: LGTM - MOC file addition for view key export dialogThe addition of the MOC file for the export view key dialog to the QT_MOC_CPP list is correct and necessary for Qt's meta-object system to work properly with the new dialog.
218-218: LGTM - Header file addition for view key export dialogThe addition of the export view key dialog header file to the BITCOIN_QT_H list is appropriate for the feature being implemented.
433-433: LGTM - Source file addition for view key export dialogThe addition of the export view key dialog source file to the BITCOIN_QT_WALLET_CPP list is correct. This properly places the new implementation in the wallet-related sources, which aligns with the feature's purpose of exporting wallet view keys.
| UniValue dumpsparkviewkey(const JSONRPCRequest& request) { | ||
| CWallet * const pwallet = GetWalletForJSONRPCRequest(request); | ||
| if (!EnsureWalletIsAvailable(pwallet, request.fHelp)) { | ||
| throw std::runtime_error("wallet not available"); | ||
| } | ||
|
|
||
| if (request.fHelp || request.params.size() != 0) | ||
| throw std::runtime_error("dumpviewkey\n\nDisplay our Spark View Key.\n"); | ||
|
|
||
| return {pwallet->GetSparkViewKeyStr()}; | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Consider adding the same security warnings as other key export functions
Since exporting view keys could potentially compromise privacy, consider implementing the same security measures as used in dumpprivkey_firo and dumpwallet_firo with authorization codes.
Run the following script to check how sensitive Spark view keys are in the codebase:
🏁 Script executed:
#!/bin/bash
# Check if Spark view keys are treated with similar security precautions as private keys
# Check for any security-related comments about Spark view keys
rg -i "spark.*(view|key).*security|security.*spark.*(view|key)" --type cpp
# Check how the Spark view key is used in the codebase
rg -A 3 "GetSparkViewKeyStr" --type cppLength of output: 1022
Security Improvement Required: Add Authorization Checks for Spark View Key Export
- The
dumpsparkviewkey()function insrc/wallet/rpcdump.cpp(lines 589–599) currently lacks additional security warnings or authorization checks. - Unlike other key export functions such as
dumpprivkey_firoanddumpwallet_firo, there are no safeguards (e.g., confirmation prompts or authorization codes) implemented for exporting the Spark view key. - Please update the function to incorporate the same security warnings and measures as the other key export functionalities to mitigate potential privacy risks.
🛠️ Refactor suggestion
Fix help message and consider adding security measures
The implementation of the dumpsparkviewkey function is generally good, but there are a few issues:
- The error message in the help text uses "dumpviewkey" instead of "dumpsparkviewkey"
- Unlike other sensitive key export functions in this file (like
dumpprivkey_firo), there are no security measures such as authorization codes - There's no check to ensure the wallet is unlocked using
EnsureWalletIsUnlocked(pwallet)
UniValue dumpsparkviewkey(const JSONRPCRequest& request) {
CWallet * const pwallet = GetWalletForJSONRPCRequest(request);
if (!EnsureWalletIsAvailable(pwallet, request.fHelp)) {
throw std::runtime_error("wallet not available");
}
if (request.fHelp || request.params.size() != 0)
- throw std::runtime_error("dumpviewkey\n\nDisplay our Spark View Key.\n");
+ throw std::runtime_error(
+ "dumpsparkviewkey\n"
+ "\nDisplay our Spark View Key.\n"
+ "\nResult:\n"
+ "\"key\" (string) The Spark view key\n"
+ "\nExamples:\n"
+ + HelpExampleCli("dumpsparkviewkey", "")
+ + HelpExampleRpc("dumpsparkviewkey", "")
+ );
+ EnsureWalletIsUnlocked(pwallet);
+
return {pwallet->GetSparkViewKeyStr()};
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| UniValue dumpsparkviewkey(const JSONRPCRequest& request) { | |
| CWallet * const pwallet = GetWalletForJSONRPCRequest(request); | |
| if (!EnsureWalletIsAvailable(pwallet, request.fHelp)) { | |
| throw std::runtime_error("wallet not available"); | |
| } | |
| if (request.fHelp || request.params.size() != 0) | |
| throw std::runtime_error("dumpviewkey\n\nDisplay our Spark View Key.\n"); | |
| return {pwallet->GetSparkViewKeyStr()}; | |
| } | |
| UniValue dumpsparkviewkey(const JSONRPCRequest& request) { | |
| CWallet * const pwallet = GetWalletForJSONRPCRequest(request); | |
| if (!EnsureWalletIsAvailable(pwallet, request.fHelp)) { | |
| throw std::runtime_error("wallet not available"); | |
| } | |
| if (request.fHelp || request.params.size() != 0) | |
| throw std::runtime_error( | |
| "dumpsparkviewkey\n" | |
| "\nDisplay our Spark View Key.\n" | |
| "\nResult:\n" | |
| "\"key\" (string) The Spark view key\n" | |
| "\nExamples:\n" | |
| + HelpExampleCli("dumpsparkviewkey", "") | |
| + HelpExampleRpc("dumpsparkviewkey", "") | |
| ); | |
| EnsureWalletIsUnlocked(pwallet); | |
| return {pwallet->GetSparkViewKeyStr()}; | |
| } |
src/Makefile.qt.include
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Copyright (c) 2013-2016 The Bitcoin Core developers | |||
| # make Copyright (c) 2013-2016 The Bitcoin Core developers | |||
There was a problem hiding this comment.
Fix unintentional makefile directive
Line 1 has been changed from a comment to a make directive by adding make at the beginning, which will cause the build system to try to execute it as a command. This appears to be unintentional.
-# make Copyright (c) 2013-2016 The Bitcoin Core developers
+# Copyright (c) 2013-2016 The Bitcoin Core developers📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # make Copyright (c) 2013-2016 The Bitcoin Core developers | |
| # Copyright (c) 2013-2016 The Bitcoin Core developers |
cassandras-lies
force-pushed
the
exportviewkey
branch
from
bc7c8e9 to
7bdac71
Compare
Rebase includes: * UI improvements (#1475) * Lelantus UI stripped * More improvements * Fixed UI hang issue during batch verification * QT hanging improvements * QT hanging fix * Review commits applied * coderabbit comments applied * more coderabbitai comments resolved --------- Co-authored-by: firstcryptoman <firstcryptoman@gmail.com> * Spark names (#1532) * Initial spark name architecture * Spark address ownership proofs implemented. * Missing files added * Check the ownership proof for spark names: initial implementation * Fixes to the core part of spark names * Added additional field (core) * Consensus parameters for spark names * Fixed mempool bug * Fixes in spark name conflict resolution * RPCs for spark names * Additional API for spark names tx creation * Changed way of checking spark name tx * Wallet API for spark name transaction creation * API changes for spark name tx creation * Added registersparkname RPC call * Spark activation check for RPC * Make spark names case-insensitive * Spark name RPC fixes * Faster lookup for spark name by spark address * Fixes for spark name/address lookup * Improvements for duplicated address detection * Fixes for spark name state * Block index entries for spark names * Make dot (.) a legit symbol in spark name * Spark name block number for testnet * Fixed restoration of old spark name data if block is disconnected * API for quick check of spark name transaction validity before the creation * added isAddressMine function * Check if the address belongs to the wallet before creating spark name transaction * Fixed fee calculation for spark name * Fix for spark names RPC * Added ability to spend to spark names in "sparkspend" RPC * UI fixes * Additional validations * Fix for crash with spend to unregistered name * Fixed fee value when registering spark name for more than one year * Spark name UI improvements * UI modifications for sending to spark name * Address book fixes related to spark names * Fixed period of validity when creating spark name through GUI * Extended spark name error info for RPC * Fixed crash on non-HD wallet * Request wallet password for spark name creation * Fixed fee calculation for the spark name tx * Fixed detection of previously used spark address for a spark name * Unit test for spark names * Additional unit tests * Fixes #1533 * getsparknamedata RPC now returns JSON object * Added "My own spark names" to the dropdown list in address book * Added an option of displaying only own spark names for RPC. Closes #1535 * Set HF block for spark names * Fixed a check for spark name block start * Added tests for correctly respecting HF block number * Check if we're over HF before spark name transaction creation * new rpc for spark name (#1552) * Fixed spark name tests * Changed HF date * Change of HF block number --------- Co-authored-by: levonpetrosyan93 <petrosyan.levon93@gmail.com> Co-authored-by: levoncrypto <levoncrypto1994@gmail.com> Co-authored-by: levoncrypto <95240473+levoncrypto@users.noreply.github.com> Co-authored-by: levonpetrosyan93 <45027856+levonpetrosyan93@users.noreply.github.com> * Export View Keys (#1543) * Add an RPC command to export the Spark view key. * Show Spark View Key in Qt. * Sigma pool closed, Extra payload extended (#1477) * Change of emission rules * Fixes for testnet * Cleaning up code and tests * Workaround for current devnet bugs * Workaround for testnet * Devnet parameter tweak * Sigma pool closed * Extra payload size limit increased * Changed HF block for testnet * Initial spark name architecture * Spark address ownership proofs implemented. * Missing files added * Check the ownership proof for spark names: initial implementation * Fixes to the core part of spark names * Added additional field (core) * Consensus parameters for spark names * Fixed mempool bug * Fixes in spark name conflict resolution * RPCs for spark names * Additional API for spark names tx creation * Changed way of checking spark name tx * Wallet API for spark name transaction creation * API changes for spark name tx creation * Added registersparkname RPC call * Spark activation check for RPC * Make spark names case-insensitive * Spark name RPC fixes * Faster lookup for spark name by spark address * Fixes for spark name/address lookup * Improvements for duplicated address detection * Fixes for spark name state * Block index entries for spark names * Make dot (.) a legit symbol in spark name * Spark name block number for testnet * Fixed restoration of old spark name data if block is disconnected * API for quick check of spark name transaction validity before the creation * added isAddressMine function * Check if the address belongs to the wallet before creating spark name transaction * Fixed fee calculation for spark name * Fix for spark names RPC * Added ability to spend to spark names in "sparkspend" RPC * UI fixes * Additional validations * Fix for crash with spend to unregistered name * Fixed fee value when registering spark name for more than one year * Spark name UI improvements * UI modifications for sending to spark name * Address book fixes related to spark names * Fixed period of validity when creating spark name through GUI * Extended spark name error info for RPC * Fixed crash on non-HD wallet * Request wallet password for spark name creation * Fixed fee calculation for the spark name tx * Fixed detection of previously used spark address for a spark name * Unit test for spark names * Additional unit tests * Fixes #1533 * Testnet HF block set * Mainnet HF block set --------- Co-authored-by: Peter Shugalev <peter@shugalev.com> Co-authored-by: levoncrypto <levoncrypto1994@gmail.com> * Build fix (#1553) * Build fix * coderabbitai comment resolved * Duplicated rpc removed * Bump version to v0.14.14.1 Spark Names (#1550) * secp256k1: CMake build system added * cmake: add cmake folder * bench: Add initial cmake support * Add initial main CMakeLists.txt * doc: add initial cmake support * univalue: add initial cmake support * zmq: add initial cmake support * crypto: add initial cmake support * wallet: add initial cmake support * src: initial add of src/CMakeLists.txt * toolchain.cmake.in: Adding toolchain.cmake.in support * crypto: add support for CMake function check. * bitcoin-cli: add CMake compilation. * firo-tx: add CMake compilation. Improve miscellaneous CMake files. * firod: add CMake compilation support. * Improved misc CMake compilation support. * Add bitcoin-config.h generation support. * gmp: fix gmp link on OS X * build: generate Linux installable package. * CMake: add tests (test_bitcoin) compilation support. * Qt: CMake GUI compilation support (Ubuntu) * src/qt: Add macOS support for GUI with CMake compilation. * depends: fix gmp compilation issue with mingw * build: Add MingW support for CMake build system * src: add backtrace compilation support macOS * src: add backtrace compilation support Linux and MinGW-w64 * CMake: apply CodeRabbitAI suggestions. * CMake: Add CI tasks for CMake build. * Remove static from functions to fix debug linking In release builds, these functions are inlined, avoiding linkage issues. Debug builds (without inlining) caused undefined references in dependent libraries due to static visibility. Removing static resolves this while maintaining intended behavior in optimized builds. * Add removed testcases and make BUILD_GUI=ON default option * Added documentation to readme.md and fixed a lelantus test issue * Fixed documentation, set ENABLE_WALLET=ON by default Remove outdated old sigma testcase * Rebase to Wed Apr 23 11:39:34 AM BST 2025 --------- Co-authored-by: levonpetrosyan93 <45027856+levonpetrosyan93@users.noreply.github.com> Co-authored-by: firstcryptoman <firstcryptoman@gmail.com> Co-authored-by: psolstice <peter@shugalev.com> Co-authored-by: levonpetrosyan93 <petrosyan.levon93@gmail.com> Co-authored-by: levoncrypto <levoncrypto1994@gmail.com> Co-authored-by: levoncrypto <95240473+levoncrypto@users.noreply.github.com> Co-authored-by: cassandras-lies <203535133+cassandras-lies@users.noreply.github.com> Co-authored-by: justanwar <42809091+justanwar@users.noreply.github.com>
PR intention
Enable exporting Spark view keys in RPC and Qt.
Code changes brief
This adds a RPC command to export Spark view keys (in mnemonic style) and adds a Qt dialog to show the same.