Fix Unclickable 'Click here' in Migration Banner

[firstcryptoman]

Enhance User Interface and Interaction for Lelantus to Spark Migration

Summary

This pull request addresses key enhancements in the UI/UX of the migration process from Lelantus to Spark within the Firo wallet. It updates the display logic for migration-related warnings and integrates security checks for wallet operations.

Changes

Code Enhancements

• Enhanced Timing and Display Logic: Added detailed calculations for days and blocks remaining until the migration period closes, improving user comprehension of the urgency and timing.
• Dynamic UI Adjustments: Updated UI elements dynamically based on the migration status and wallet state, improving user engagement and prompting timely actions.
• Passphrase Dialog Checks: The system now verifies if the wallet is locked and, if so, prompts the user with a passphrase dialog. This is facilitated through a user-friendly interface that ensures secure and authorized access.

Screenshots

Screen.Recording.2024-06-15.at.19.22.16.mov

[coderabbitai]

Walkthrough

The recent update to the cryptocurrency wallet's OverviewPage in the src/qt directory focuses on improving the user experience and functionality for migrating Lelantus coins to Spark. Key changes include enhancing the user interface to inform users of the migration window, integrating wallet unlocking via AskPassphraseDialog, and handling migration conditions based on wallet encryption status and coin availability.

Changes

File Path	Change Summary
src/qt/overviewpage.cpp	Added passphrase dialog for unlocking the wallet, calculated migration window closure days, updated user warnings, improved migration logic.
src/qt/overviewpage.h	Renamed lelantusGracefulPeriod to migrationWindowClosesIn and currentBlock to blocksRemaining to align with new functionality.

Poem

In code that dances, swift and bright,
Tokens morph from dark to light.
Lelantus fades, Spark takes its place,
With warnings, prompts, a smoother pace.
Unlock, migrate—your crypto flight,
Securely done, deep in the night. 🚀🔐

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

src/qt/overviewpage.cpp (1)

385-396: The updates to onRefreshClicked() method are correct and improve user information on migration status. Consider adding a comment explaining the choice of 570 for approxBlocksPerDay.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fc2e876 and d4f9702.

Files selected for processing (2)

• src/qt/overviewpage.cpp (3 hunks)
• src/qt/overviewpage.h (1 hunks)

Additional comments not posted (2)

src/qt/overviewpage.h (1)

89-90: Renaming of variables enhances clarity and better reflects their intended use in the migration context.

src/qt/overviewpage.cpp (1)

22-22: Inclusion of askpassphrasedialog.h is necessary for passphrase handling in migration logic.