Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden Schnorr/Chaum proofs #1388

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

AaronFeickert
Copy link
Contributor

PR intention

Hardens Schnorr and Chaum proof verification in Spark transactions.

Code changes brief

Input keys in Schnorr and Chaum proofs ought not to be zero. This PR ensures these things don't happen.

Copy link
Contributor

@psolstice psolstice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test before the release, otherwise looks good

Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reindex on testnet passed

@reubenyap reubenyap merged commit 1d6f2b7 into firoorg:master Jan 15, 2024
5 checks passed
@AaronFeickert AaronFeickert deleted the proof-zero-keys branch January 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants