Unpad memos #1381
Merged
Unpad memos #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
unpad-memos
branch
2 times, most recently
from
d438f3f
to
3523daf
Compare
levonpetrosyan93
approved these changes
Dec 19, 2023
AaronFeickert
force-pushed
the
unpad-memos
branch
from
3523daf
to
0ce5d20
Compare
psolstice
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a recipient decrypts a memo during coin identification, the memo is still padded, which is poor user experience.
This PR includes the memo length as part of encrypted recipient data, and removes the padding during coin identification. This ensures that the original unpadded memo is provided to the recipient.
Closes #1380.