Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigma transaction size not being calculated correctly by coin control #562

Closed
reubenyap opened this issue Jul 30, 2019 · 3 comments · Fixed by #568
Closed

Sigma transaction size not being calculated correctly by coin control #562

reubenyap opened this issue Jul 30, 2019 · 3 comments · Fixed by #568
Assignees
Milestone

Comments

@reubenyap
Copy link
Member

Bug reported by @goodc0re on Telegram

Actual behaviour

Coin control is calculating the size of the Sigma spend transaction at 226 bytes and estimating fees based on that.
Actual is 1.4 kB which is calculated correctly on the confirmation screen.

image

Desired behaviour

Coin control for Sigma should calculate it based on Sigma spend size not regular transparent transactions.

Steps to reproduce

  • Go to coin control, inputs, select a mint.
  • Go to spend, enter in an address and select the whole amount of the mint. Make sure Subtract fee from amount is selected.
  • See the difference between Coin Control estimation and actual fee.
@FreakyMaryk
Copy link
Contributor

@levonpetrosyan93 @reubenyap
Verified. Can be closed
1)
image
2)
image

@FreakyMaryk
Copy link
Contributor

Waiting requested changes. And than re-check it again

@reubenyap reubenyap modified the milestones: v0.13.8.3, v0.13.8.4 Aug 2, 2019
@reubenyap
Copy link
Member Author

pushed to 13.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants