Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wrong transaction size estimation #568

Merged
merged 5 commits into from
Aug 7, 2019
Merged

Fixing wrong transaction size estimation #568

merged 5 commits into from
Aug 7, 2019

Conversation

levonpetrosyan93
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 commented Aug 2, 2019

Fixes #562

@reubenyap reubenyap added this to the v0.13.8.3 milestone Aug 2, 2019
@reubenyap reubenyap added the bug label Aug 2, 2019
@FreakyMaryk FreakyMaryk self-requested a review August 2, 2019 07:24
FreakyMaryk
FreakyMaryk previously approved these changes Aug 2, 2019
Copy link
Contributor

@FreakyMaryk FreakyMaryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

Copy link
Contributor

@ultimaweapon ultimaweapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revise logic due to there is 2 modes for it.

src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
@reubenyap reubenyap modified the milestones: v0.13.8.3, v0.13.8.4 Aug 2, 2019
@FreakyMaryk FreakyMaryk self-requested a review August 2, 2019 13:45
a-bezrukov
a-bezrukov previously approved these changes Aug 5, 2019
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
@ultimaweapon ultimaweapon merged commit e366201 into master Aug 7, 2019
@ultimaweapon ultimaweapon deleted the fix_txsize branch August 7, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sigma transaction size not being calculated correctly by coin control
8 participants