add IS_PIN_SPI(p) to Boards.h #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the Teensy boards also define SS, MOSI, MISO and SCK so please add the macro for those boards as well. |
|
Looks like the wiring boards define the SPI pins as well: see BoardDefs.h. |
soundanalogous
added a commit
that referenced
this pull request
Feb 17, 2013
add IS_PIN_SPI(p) to Boards.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a macro 'IS_PIN_SPI(p)' to Boards.h.
While SPI is not yet a feature in Firmata I can use this info in EthernetFirmata to exclude the SPI-pins from Capability- and PinMode-query (and hindering systemReset to set these pins to the default OUTPUT) which would interfere with the running Ethernet-lib and bring down an active IP-connection.
Since I didn't have reliable SPI-info at hand for the non-arduino boards I made IS_PIN_SPI(p) evaluate to '0' for all boards that do not have this macro defined.