force digital or analog message when enabling digital port or analog pin reporting #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soundanalogous
added a commit
that referenced
this pull request
Oct 26, 2014
force digital or analog message when enabling digital port or analog pin reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reports the digital port value upon the client enabling a digital port and it reports the analog pin value upon the client enabling that analog pin for reporting. This is a feature that has been requested to better support non-serial based connections such as ethernet, wi-fi and bluetooth where it's possible the connection may be broken and reestablished. If a client library reenables analog pins and digital pins upon reestablishing a connection, then with this change the respective values will be reported so the client is updated with the current state of the pins. Care may be needed in the client library however to ensure that there are no false triggers due to the reported port and pin values.
This feature has been used in ConfigurableFirmata for almost a year with no issues reported.