Skip to content

[QUESTION] What is the motivation for MAX_DATA_BYTES? #328

Closed
@zfields

Description

@zfields

MAX_DATA_BYTES is the only reason I need to include FirmataConstants.h in FirmataParser.h.

Depending on the answer to a few questions, I would like to offer to provide a replacement.

  1. Does MAX_DATA_BYTES play a larger role than defining the size of the state?
  2. Does the array storedInputData need to be on the stack, or was this done out of convenience?
  3. Would a char * stored on the heap, using realloc() be an acceptable substitute?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions