Skip to content

Conversation

@emborden
Copy link

@emborden emborden commented Jan 6, 2020

Topic

TP Link: https://sbf.tpondemand.com/entity/57214
SBF PR: firespring/SBF#1598

How to test

create a log in api:console create a log with filters and password to a hash notice that the hash will filter the content that is passed in the string

Setup

  • rake switch BRANCH=story/TP-57214

Functionality

  • added the ability to add filters based on log instances.

@emborden emborden changed the title [Story/tp 57214]:Prevent reuse of Password reset token [Story/TP-57214]:Prevent reuse of Password reset token Jan 6, 2020

class Hedgelog
VERSION = '0.1.12'
VERSION = '0.2.1.alpha1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference standard naming would be to reset the lower significance number when publishing. Since this is a minor version bump, the patch version should be reset, i.e. 0.2.0.alpha.1

https://semver.org/#spec-item-7

Copy link
Author

@emborden emborden Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was meant to be 0.2.0.alpha1, but when I published I published as just 0.2.0 on accident. So I bumped to 0.2.1.alpha1. to show I was in beta testing, and because of so that minor changes I made to pass spec and rubocop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants