-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -reference_checkpoint option to aws_build_dcp_from_cl.sh #43
base: dev
Are you sure you want to change the base?
Conversation
If passed, the path given to -reference_checkpoint is used to `read_checkpoint -incremental` at the appropriate place in the design flow for Vivado to do an incremental implementation Also adds `report_incremental_reuse -hierarchical` reporting at the various stages of the flow.
@davidbiancolin this is the changeset I made so that I could buildafi a configuration that didn't have assertions and then in the recipe where I mix-in However, when I try to use the new option to the script, I hit this:
I see what's happening now that I look at this again. The reference_checkpoint path is getting pulled into the |
It's my standard favorite thing to hate where the empty string needs to be passed and parsed correctly because the AWS vivado TCL script uses only positional arguments and doesn't support Needing to pass the empty-string and getting the quoting correct is fraught. |
trying to do it after link_design or after CL_synthesis leads to an error saying ERROR: [Vivado 12-4846] Found memory core that needs to be (re)generated. Please run opt_design or implement_mig_cores prior to launching 'read_checkpoint -incremental'.
If passed, the path given to -reference_checkpoint is used to
read_checkpoint -incremental
at the appropriate place in thedesign flow for Vivado to do an incremental implementation
Also adds
report_incremental_reuse -hierarchical
reportingat the various stages of the flow.
If we end up wanting to use this, with newer Vivado we should probably: