Skip to content

Add temporarily removed animation on result view back #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firemaples merged 1 commit into from
Apr 6, 2024
Merged

Add temporarily removed animation on result view back #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...src/main/java/tw/firemaples/onscreenocr/floatings/compose/resultview/ResultViewContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package tw.firemaples.onscreenocr.floatings.compose.resultview

import android.content.res.Configuration
import android.graphics.Rect
import androidx.compose.animation.animateContentSize
import androidx.compose.animation.core.animateIntOffsetAsState
import androidx.compose.foundation.Image
import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
Expand Down Expand Up @@ -95,10 +97,10 @@ fun ResultViewContent(
mutableStateOf(IntOffset(state.highlightUnion.left, state.highlightUnion.top))
}

// val animOffset by animateIntOffsetAsState(
// targetValue = targetOffset.value,
// label = "result panel position",
// )
val animOffset by animateIntOffsetAsState(
targetValue = targetOffset.value,
label = "result panel position",
)

ResultPanel(
modifier = Modifier
Expand All @@ -114,9 +116,8 @@ fun ResultViewContent(
padding = 16.dp.dpToPx(),
verticalSpacing = 4.dp.dpToPx(),
)
.offset { targetOffset.value },
// .offset { animOffset }
// .animateContentSize(),
.offset { animOffset }
.animateContentSize(),
viewModel = viewModel,
textSearchEnabled = state.textSearchEnabled,
fontSize = state.fontSize,
Expand Down