Compile cleanup #222
Merged
Compile cleanup #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. This completes what I wanted to do here. Turns out that CI works when I fixed cmake to work on Windows. @psychocrypt Can you review the changes? |
|
thx for this nice PR |
psychocrypt
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress, but pushing it as PR since the changes break the CI.
Rationale for removing the header is that since we are no longer hacking out the build on Windows we should be doing things properly (header vs lib mismatch). @psychocrypt can you have a look at the CI script and add a fix?