Fix handling of stratum+tcp:// format #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocrypt
requested changes
Jul 9, 2017
| @@ -56,7 +56,10 @@ bool plain_socket::set_hostname(const char* sAddr) | |||
| sAddrMb[ln] = '\0'; | |||
|
|
|||
| if ((sTmp = strstr(sAddrMb, "//")) != nullptr) | |||
| { | |||
| sTmp += 2; | |||
There was a problem hiding this comment.
This can produce a buffer overflow if the user add ony stratum+tcp// as address, can you please add a check that the new pointer is not behind '/0'
There was a problem hiding this comment.
I think you might be reading the code wrong. This actually got me to when I was writing it if you look at it carefully =).
In case the sAddrMb = "x//\0", sTmp = "//\0", and after addition, sTmp = "\0". strlen(sTmp) = 0, so the args to memmove are
memmove(sAddrMb, sTmp ( = "\0"), 1), so sAddrMb = "\0"
There is no need to check for being behind \0 because the searched for string has a fixed length.
There was a problem hiding this comment.
Yes you are right. thx for the clarification.
psychocrypt
approved these changes
Jul 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for #194