Skip to content

Commit

Permalink
move the config viewer_enabled to the general section because its n…
Browse files Browse the repository at this point in the history
…ot only related to the database logger adapter
  • Loading branch information
sylvainraye authored and colinmollenhour committed May 12, 2014
1 parent a176642 commit 01ab8c8
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public function reportAjaxAction()
*/
protected function _isAllowed()
{
$flagEnabled = Mage::getStoreConfigFlag('logger/db/viewer_enabled');
$flagEnabled = Mage::getStoreConfigFlag('logger/general/viewer_enabled');
$flagAcl = Mage::getSingleton('admin/session')->isAllowed('system/logger');

return $flagEnabled && $flagAcl;
Expand Down
2 changes: 1 addition & 1 deletion src/app/code/community/FireGento/Logger/etc/adminhtml.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<sort_order>60</sort_order>
<action>adminhtml/logger/index</action>
<depends>
<config>logger/db/viewer_enabled</config>
<config>logger/general/viewer_enabled</config>
</depends>
<children>
<grid_viewer translate="title" module="firegento_logger">
Expand Down
2 changes: 1 addition & 1 deletion src/app/code/community/FireGento/Logger/etc/config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ USER AGENT: %HTTP_USER_AGENT%
FILE: %file%:%line%
%message%]]></format>
<max_backtrace_lines>0</max_backtrace_lines>
<viewer_enabled>0</viewer_enabled>
</general>
<default>
<priority>default</priority>
Expand All @@ -172,7 +173,6 @@ FILE: %file%:%line%
</mailconfig>
<db>
<priority>default</priority>
<viewer_enabled>0</viewer_enabled>
<max_days_to_keep>45</max_days_to_keep>
</db>
<xmpp>
Expand Down
16 changes: 8 additions & 8 deletions src/app/code/community/FireGento/Logger/etc/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@
end of each page processing. <br />
]]></comment>
</use_queue>
<viewer_enabled translate="label">
<label>Enable Log Viewer</label>
<frontend_type>select</frontend_type>
<source_model>adminhtml/system_config_source_yesno</source_model>
<sort_order>10</sort_order>
<show_in_default>1</show_in_default>
<comment>If "No", the "View Error Log" menu item will not be present.</comment>
</viewer_enabled>
</fields>
</general>
<default translate="label">
Expand Down Expand Up @@ -196,14 +204,6 @@
<show_in_default>1</show_in_default>
<comment>Choose the lowest priority level to be logged.</comment>
</priority>
<viewer_enabled translate="label">
<label>Enable Log Viewer</label>
<frontend_type>select</frontend_type>
<source_model>adminhtml/system_config_source_yesno</source_model>
<sort_order>10</sort_order>
<show_in_default>1</show_in_default>
<comment>If "No", the "View Error Log" menu item will not be present.</comment>
</viewer_enabled>
<max_days_to_keep translate="label">
<label>Maximum days to keep log entries</label>
<frontend_type>text</frontend_type>
Expand Down

0 comments on commit 01ab8c8

Please sign in to comment.