Skip to content

Refine message on fenix 2654#5816

Open
fatadel wants to merge 4 commits intofirefox-devtools:mainfrom
fatadel:refine-message-on-fenix-2654
Open

Refine message on fenix 2654#5816
fatadel wants to merge 4 commits intofirefox-devtools:mainfrom
fatadel:refine-message-on-fenix-2654

Conversation

@fatadel
Copy link
Contributor

@fatadel fatadel commented Feb 5, 2026

Closes #2654.

Before

Screenshot_1770294748

After

Screenshot_1770294626

@fatadel fatadel requested review from canova, julienw and mstange February 5, 2026 12:35
@fatadel fatadel requested a review from a team as a code owner February 5, 2026 12:35
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.55%. Comparing base (5445a18) to head (afe9b31).
⚠️ Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
src/components/app/Home.tsx 61.11% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5816      +/-   ##
==========================================
- Coverage   85.56%   85.55%   -0.02%     
==========================================
  Files         320      320              
  Lines       31419    31430      +11     
  Branches     8649     8651       +2     
==========================================
+ Hits        26884    26890       +6     
- Misses       4104     4109       +5     
  Partials      431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I see that the first paragraph is saying that the profiling requires Firefox desktop, but in the second paragraph we tell them that they can also use the on device profiling. I think it would confuse our users. The old wording from the issue was actually suggested before we supported on device profiling, so it's not up-to-date anymore. See also my suggestions below.

Comment on lines +412 to +416
Recording performance profiles currently requires{' '}
<a href="https://www.firefox.com/en-US/browsers/desktop/">
Firefox for Desktop
</a>
. However, existing profiles can be viewed in any modern desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it looks like we have 2 different instructions now that kinda say the opposite things. Since we have a Localized component below that says it's possible to profile on an Android device, "Recording performance profiles currently requires Firefox for Desktop" is no longer true. Can we move the android on device profiling above, and add the remote profiling instruction below?

For the wording of remote profiling, maybe something like:

You can also profile Firefox for Android remotely from a desktop
computer. For more information, please consult this documentation:{' '}
<a>Profiling Firefox for Android remotely</a>.

<a>Profiling Firefox for Android directly on device</a>.
</p>
</Localized>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording is more suitable for the desktop message, since it says "You can also profile Firefox for Android.". Instead, I would prefer to have a new ftl key with a better wording suited specifically for Firefox for Android.

Maybe something like:

Firefox for Android can be profiled directly on this device. For
more information, please consult this documentation:{' '}
<a>Profiling Firefox for Android directly on device</a>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect Fenix to display a better message in the home page

3 participants