Tweak dark mode colours.#5767
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5767 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 317 317
Lines 31216 31216
Branches 8595 8499 -96
=======================================
Hits 26756 26756
Misses 4030 4030
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
force-pushed
the
tweak-dark-mode-colors
branch
from
0c497b9 to
48f843a
Compare
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks for the changes! The new colors look better indeed. I like that they are closer to the Firefox UI and DevTools dark mode colors. Let's land it.
Not for this PR, but the only places I would slightly prefer the old tinted colors are that the home page and the profile loading screen. I think it's because of the blue background color, to me it looks like 2 colors fit better compared to the blue background + black/dark gray-ish content background.
See before:
And after:
And similar for the profile loading
Before:
After:
But an opposing argument could be having cohesive color palette between the homepage and the profile analysis page. But again, the blue background on the homepage is kinda unique and we don't use it in the background in the analysis page. I don't feel very strongly about this but wanted to get your opinion as well. What do you think?
And of course I'm happy to land this PR this way, and think about the improvements later after discussing them.
Also put the body background on the root element. Fixes part of firefox-devtools#5773.
mstange
force-pushed
the
tweak-dark-mode-colors
branch
from
48f843a to
1de8aea
Compare
mstange
force-pushed
the
tweak-dark-mode-colors
branch
from
1de8aea to
1d5d774
Compare
|
I agree, those views look better with ink. I've made that change and also added two commits for #5773. Hopefully I've not broken anything on the way. |
Lots of exciting changes 🎉: [arai-a] Put radio buttons into labels (#5738) [DaniPopes] Update comment for "unique-string" (#5741) [Karan Pradhan] Hide tooltip filter button in non-sticky tooltips and add hideFilterButton tests (#5718) [arai-a] Add a menu to copy the Marker Table as text (#5732) [arai-a] Make the entire list item clickable for the "Full Range" (#5742) [Markus Stange] Move symbol table demangling out of SymbolStore into SymbolProvider (#5746) [Markus Stange] Remove SVG asset imports from profile-data.ts (#5747) [arai-a] Do not apply sticky tooltip on double click (#5754) [arai-a] Skip the ChartCanvas redraw on the Viewport's internal default state usage (#5744) [Markus Stange] Stop blindly extracting uint8array.buffer after calling compress() (#5753) [Markus Stange] In the assembly view state, refer to the current symbol by index (#5755) [Markus Stange] Fix "scroll to hotspot" functionality in the source view + assembly view (#5759) [Markus Stange] Keep the colorField markerSchema field when processing profiles in the gecko format (#5760) [Markus Stange] Implement dark mode (#5740) [Markus Stange] Fix light-mode colors (#5765) [Markus Stange] Tweak dark mode colours. (#5767) [Nazım Can Altınova] Enable some basic type-aware lints (#5775) [Markus Stange] Allow seeing different assembly code for the same function (#5349) [fatadel] Refine tree view a11y (#5779) [fatadel] Align double-click behavior of stack chart with flame graph (#5782) [Markus Stange] Split gz.ts properly into node and browser variants (#5764) [Markus Stange] Simplify and optimize the computation of per-call-node line and address timings (#5770) [Nazım Can Altınova] Move the dark mode toggle to devtools console (#5783) [Nazım Can Altınova] 🔃 Sync: l10n -> main (Jan 27, 2026) (#5785) [Nazım Can Altınova] Improve Chrome importer marker payload logic (#5717) [Markus Stange] Add a Focus Self transform (#5774) [Nazım Can Altınova] Enable the Turkish locale in production (#5786) And huge thanks to our localizers 🎉 : be: Mikalai Udodau de: Ger de: Michael Köhler el: Jim Spentzos en-CA: chutten en-CA: Saurabh en-GB: Ian Neal en-GB: Saurabh es-CL: ravmn fy-NL, nl: Fjoerfoks fr: Skywarp fr: Théo Chevalier fur: Fabio Tomat fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Fjoerfoks nl: Mark Heijl pt-BR: Marcelo Ghelman ru: berry ru: Valery Ledovskoy sv-SE: Andreas Pettersson tr: Grk zh-CN: Olvcpr423 zh-CN: wxie zh-TW: Pin-guang Chen
2 participants
Deploy preview home, Deploy preview profile
This removes the blue tint and fixes lots of small things.
Light mode (should be unchanged compared to current production):
Dark mode with fix:
Dark mode before fix:
