WIP: Namespaced AppContext
#16
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
requested changes
Aug 20, 2025
JHopeCollins
commented
Aug 27, 2025
connorjward
reviewed
Sep 1, 2025
I'd be fine with that. I can take out that part of the docstring so the only way we tell users to use the |
dham
reviewed
Sep 3, 2025
| with opts.inserted_options(): | ||
| default = MyCustomData(10) | ||
| data = appctx.get('solver_custompc_somedata', default) |
connorjward
requested changes
Sep 3, 2025
| with opts.inserted_options(): | ||
| default = MyCustomData(10) | ||
| data = appctx.get('solver_custompc_somedata', default) |
There was a problem hiding this comment.
Please create an issue describing what was discussed in the meeting about global options prefixes. I'd have loved to say more but my wifi was terrible!
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding Firedrake PR: firedrakeproject/firedrake#4526