Skip to content

Always mark unmarked tests as 'parallel[1]' #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

connorjward
Copy link
Collaborator

@connorjward connorjward commented Jun 24, 2025

This means we can avoid the clunky

-m "not parallel or parallel[1]"

I have tested this locally but I don't know that there is a satisfactory way to test this on CI.

This means we can avoid the clunky

    -m "not parallel or parallel[1]"
@connorjward connorjward requested a review from JHopeCollins June 24, 2025 08:17
@JHopeCollins
Copy link
Member

I have tested this locally but I don't there is a satisfactory way to test this on CI.

Can you make one test marked parallel[1] and another without a parallel mark, then query pytest for how many tests it finds with --co -m parallel[1]?

Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can look at how/whether to test later as it'll take some of non-standard checking.

@connorjward connorjward merged commit 232bd53 into main Jun 25, 2025
25 checks passed
@connorjward connorjward deleted the connorjward/always-mark branch June 25, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants