Add a demo on Carstensen-Gedicke lower bounds for the Dirichlet Poisson eigenproblem - #5308
Merged
Merged
Conversation
pefarrell
force-pushed
the
pefarrell/poisson_adaptive_eigenvalue_demo
branch
from
July 31, 2026 15:50
2dd698c to
dc36f32
Compare
pbrubeck
reviewed
Jul 31, 2026
Contributor
Author
|
I don't know why the run is failing, everything looks fine: https://github.com/firedrakeproject/firedrake/actions/runs/30665694261 Any ideas? |
UZerbinati
reviewed
Aug 1, 2026
…py.rst Co-authored-by: Umberto Zerbinati <umberto.zerbinati@maths.ox.ac.uk>
…om:firedrakeproject/firedrake into pefarrell/poisson_adaptive_eigenvalue_demo
Contributor
Author
|
I've added a comment about eigenvalue multiplicity, and cited Hu et al. |
pbrubeck
reviewed
Aug 3, 2026
pbrubeck
reviewed
Aug 3, 2026
pbrubeck
reviewed
Aug 3, 2026
pbrubeck
reviewed
Aug 3, 2026
pbrubeck
reviewed
Aug 3, 2026
pbrubeck
reviewed
Aug 3, 2026
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
pbrubeck
reviewed
Aug 3, 2026
pbrubeck
reviewed
Aug 3, 2026
pbrubeck
reviewed
Aug 3, 2026
UZerbinati
previously approved these changes
Aug 3, 2026
UZerbinati
left a comment
UZerbinati
left a comment
Contributor
There was a problem hiding this comment.
I've added one reference, but except from that I'm very happy with this :)
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com> Co-authored-by: Umberto Zerbinati <umberto.zerbinati@maths.ox.ac.uk>
UZerbinati
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It uses computable lower and upper bounds to drive an adaptive algorithm with guaranteed error control.