Skip to content

Allow in place operators to modify coordinates #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dham wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

Allow in place operators to modify coordinates #5214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firedrake/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2410,6 +2410,8 @@ def coordinates(self) -> "Function":

@coordinates.setter
def coordinates(self, value):
if value is self.coordinates:
return
message = """Cannot re-assign the coordinates.

You are free to change the coordinate values, but if you need a
Expand Down
21 changes: 21 additions & 0 deletions tests/firedrake/meshes/test_modify_coordinates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from firedrake import *
import numpy as np


def test_scale_coordinates():

m = UnitSquareMesh(4, 4)
m.coordinates *= 2

assert np.allclose(assemble(Constant(1)*dx(domain=m)), 4.0)


def test_addto_coordinates():

m = UnitSquareMesh(4, 4)
X = SpatialCoordinate(m)
xf = Function(m.coordinates.function_space())
xf.interpolate(X)
m.coordinates += xf

assert np.allclose(assemble(Constant(1)*dx(domain=m)), 4.0)
Loading