Ensemble methods dispatch to MPI methods for non-Firedrake types #4580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iredrake datatypes
connorjward
reviewed
Sep 22, 2025
firedrake/ensemble/ensemble.py
Outdated
Comment on lines
16
to
17
| # if only kwargs are given we need to get the | ||
| # first kw value instead of the first arg. |
There was a problem hiding this comment.
I'm not sure about this. One would expect ensemble.bcast(op=MPI.SUM, f=myfunction) to be isomorphic to ensemble.bcast(f=myfunction, op=MPI.SUM). If you're doing things with functools.partial this might get confusing.
I wonder if it might be a good idea to use / in the function signature (https://www.srcecde.me/posts/2024/02/asterisk-and-forward-slash-as-function-parameters-python/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means the call site for
Function/Cofunctionlooks the same as the call site for non-Firedrake types.Currently to send a non-Firedrake type:
This PR changes it to: