Some fixes for Cofunction controls
#4541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmaddison
force-pushed
the
jrmaddison/cofunction_controls
branch
from
84efd8b to
4d482b8
Compare
firedrake/adjoint_utils/function.py
Outdated
Comment on lines
345
to
347
| def _ad_init_object(cls, obj): | ||
| from firedrake import Cofunction | ||
| return Cofunction(cls.function_space()).assign(obj) |
There was a problem hiding this comment.
Why cls and not self here?
There was a problem hiding this comment.
Yes, and should be a classmethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes which allow
Cofunctioncontrols to be used in some configurations.tao_type_nls is xfailed as this leads to an obscure error within UFL.