Implement per communicator universal identifiers for Firedrake objects #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Jun 14, 2024
wence-
reviewed
Jun 14, 2024
connorjward
previously approved these changes
Jun 18, 2024
It wasn't before, I need to resurrect my ngsPETSc branch, turns out I needed it after all... |
JDBetteridge
force-pushed
the
JDBetteridge/fix_uid
branch
from
8908e15
to
7a52eb1
Compare
dham
previously approved these changes
Jun 19, 2024
JDBetteridge
commented
Jun 19, 2024
connorjward
approved these changes
Jun 19, 2024
Ig-dolci
pushed a commit
that referenced
this pull request
Jul 6, 2024
#3633) * Implement per communicator universal identifiers for Firedrake objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This requires NGSolve/ngsPETSc#41 to be merged simultaneously.
Fixes #3631 and potentially #3628.