Make VTK optional #3324
Merged
Make VTK optional #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Are you still going to distribute the wheels? |
Member
Author
|
Probably, although VTK are getting better at releasing up to date wheels: https://pypi.org/project/vtk/#history |
connorjward
requested changes
Jan 15, 2024
connorjward
reviewed
Jan 15, 2024
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I am happy with this. @JDBetteridge believes that some bikeshedding/further API thought is required before merging.
JDBetteridge
force-pushed
the
JDBetteridge/optional_vtk
branch
from
b553497 to
8785a92
Compare
Member
Author
|
@danshapero can you remind me what your motivation was for this change? #3117 (comment) |
JDBetteridge
force-pushed
the
JDBetteridge/optional_vtk
branch
6 times, most recently
from
2d03446 to
7c0b2d4
Compare
JDBetteridge
force-pushed
the
JDBetteridge/optional_vtk
branch
from
7c0b2d4 to
b642ecb
Compare
Member
Author
|
I think this is ready, I think I want to kick the "move |
connorjward
previously approved these changes
Mar 5, 2024
Member
Author
|
This also needs announcing in general before being merged as it has user facing changes |
JDBetteridge
force-pushed
the
JDBetteridge/optional_vtk
branch
from
97442f0 to
4218cd5
Compare
dham
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent issues on ARM based Mac + the long standing issue where we have to distribute VTK wheels prompted making VTK an optional dependency.