Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hiptmair multigrid PC #2707

Merged
merged 26 commits into from
Mar 15, 2023
Merged

Add Hiptmair multigrid PC #2707

merged 26 commits into from
Mar 15, 2023

Conversation

pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Jan 10, 2023

A Python PC implementing a two-level method arising from a Hiptmair decomposition.

Allows a user-provided tabulation of grad (curl) to transfer scalar (vector) potentials in Vc into the target function space Vf. This gives flexibility to use a sparse matrix for FDM elements, or to do it matrix-free via Interpolator(grad(TestFunction(Vc)), Vf) when the transpose operation becomes available.

Copy link
Contributor

@pefarrell pefarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test?

firedrake_citations/__init__.py Outdated Show resolved Hide resolved
firedrake/preconditioners/hiptmair.py Outdated Show resolved Hide resolved
firedrake/preconditioners/hiptmair.py Outdated Show resolved Hide resolved
firedrake/preconditioners/hiptmair.py Outdated Show resolved Hide resolved
firedrake/preconditioners/hiptmair.py Show resolved Hide resolved
tests/multigrid/test_hiptmair.py Outdated Show resolved Hide resolved
firedrake/preconditioners/hiptmair.py Show resolved Hide resolved
pefarrell
pefarrell previously approved these changes Jan 19, 2023
dham
dham previously approved these changes Feb 8, 2023
JDBetteridge
JDBetteridge previously approved these changes Feb 8, 2023
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved

firedrake/preconditioners/hiptmair.py Show resolved Hide resolved
JDBetteridge
JDBetteridge previously approved these changes Feb 9, 2023
@JDBetteridge
Copy link
Member

@pbrubeck Please fix the conflicts and then I can review, thanks.

Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(previously approved)

@JDBetteridge JDBetteridge merged commit 44b7b6e into master Mar 15, 2023
@JDBetteridge JDBetteridge deleted the pbrubeck/hiptmair-pc branch March 15, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants