Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check backward compatibility of UFL dualspace #2305

Closed
wants to merge 11 commits into from

Conversation

nbouziani
Copy link
Contributor

This PR is just for checking if the upcoming UFL dual space update breaks the current Firedrake.

UFL PR: firedrakeproject/ufl#25

@nbouziani
Copy link
Contributor Author

This currently fails because firedrake.Constant inherits ufl.Coefficient and the latter performs some checks on the function space (if it is dual or not) in __new__. This has been fixed in #2294 and is I think more of a design issue at the Firedrake level (we could have firedrake.Constant inheriting ufl.Constant). It is something that is (I think) specific to Firedrake so it won't affect other UFL subpackages that don't have this design.

@nbouziani nbouziani closed this Mar 18, 2023
@nbouziani nbouziani deleted the dualspace_backward_compatibility branch March 18, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant