Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit Dual Space support in Assemble #2034

Closed
wants to merge 34 commits into from
Closed

Explicit Dual Space support in Assemble #2034

wants to merge 34 commits into from

Conversation

indiamai
Copy link
Contributor

@indiamai indiamai commented Apr 21, 2021 •
edited
Loading

Work that still needs to be done:

  • Add Hermitian transpose to petsc4py
  • Support for Mixed Spaces

@indiamai indiamai changed the title Use dualspace ufl branch in ci Explicit Dual Space support in Assemble May 25, 2021
@wence-
Copy link
Contributor

wence- commented Jun 10, 2021

Add Hermitian transpose to petsc4py

I think I did this and I just need to update our petsc branch.

wence-
wence- reviewed Jun 10, 2021
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks great! I have a lot of comments but they are mostly small things I think.

firedrake/assemble.py Show resolved Hide resolved
firedrake/assemble.py Show resolved Hide resolved
firedrake/assemble.py Show resolved Hide resolved
firedrake/assemble.py Show resolved Hide resolved
firedrake/assemble.py Show resolved Hide resolved
firedrake/assemble.py Show resolved Hide resolved
firedrake/assemble.py Show resolved Hide resolved
scripts/firedrake-zenodo Outdated Show resolved Hide resolved
scripts/firedrake-install Outdated Show resolved Hide resolved
tests/regression/test_assemble_formbase.py Show resolved Hide resolved
This was referenced Dec 6, 2021
Merged
Merged
@nbouziani nbouziani mentioned this pull request Dec 15, 2021
Merged
@nbouziani nbouziani closed this Sep 19, 2023
@nbouziani nbouziani deleted the dualspace branch May 3, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@indiamai @wence- @nbouziani @colinjcotter