Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor assemble #1983

Merged
merged 15 commits into from
Apr 14, 2021
Merged

Refactor assemble #1983

merged 15 commits into from
Apr 14, 2021

Commits on Mar 31, 2021

  1. Refactor assemble

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    dd52618 View commit details
    Browse the repository at this point in the history

  2. Parloops now cached on form

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    2c4f93a View commit details
    Browse the repository at this point in the history

  3. Replace assemble_now with assembly_type

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    1b795c6 View commit details
    Browse the repository at this point in the history

  4. Fix EquationBC tests

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    a06b28d View commit details
    Browse the repository at this point in the history

  5. Squashed commit of the following: 

    commit 9e4f22daacea52b347df170e5c2cd1ba5cd7395e
Author: Connor Ward <c.ward20@imperial.ac.uk>
Date:   Mon Mar 8 15:20:32 2021 +0000

    Fix BC bug, I deleted a line by accident...

commit 8b89de98e3776828a2a2aa3f18c9235b76bdae7b
Author: Connor Ward <c.ward20@imperial.ac.uk>
Date:   Mon Mar 8 13:51:46 2021 +0000

    WIP: Trying to fix assembly_rank

commit 0b28cce64c1519d42eb720c16968d65ad38129d3
Author: Connor Ward <c.ward20@imperial.ac.uk>
Date:   Mon Mar 8 12:02:36 2021 +0000

    WIP: test_assemble passes

commit 18e30e2fef9696d81b0b9aea0e913c710fc4e09f
Author: Connor Ward <c.ward20@imperial.ac.uk>
Date:   Mon Mar 8 11:43:08 2021 +0000

    WIP: Coding done, now just bug fixing needed

commit 0b33080
Author: Connor Ward <c.ward20@imperial.ac.uk>
Date:   Fri Feb 26 16:56:57 2021 +0000

    WIP: Add _AssemblyOpts namedtuple to reduce boilerplate
    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    149af88 View commit details
    Browse the repository at this point in the history

  6. Tidy EquationBC checks

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    bbb54fb View commit details
    Browse the repository at this point in the history

  7. Remove make_parloops_inner

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    7ecd748 View commit details
    Browse the repository at this point in the history

  8. Rename AssemblyRank to _AssemblyRank

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    9c15d13 View commit details
    Browse the repository at this point in the history

  9. Add docstrings and lift _get_mat_type()

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5dbcaa3 View commit details
    Browse the repository at this point in the history

  10. Add _AssemblyType IntEnum

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    ddd6e81 View commit details
    Browse the repository at this point in the history

  11. Add comprehensive cache key

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    c56e2ee View commit details
    Browse the repository at this point in the history

  12. Add cache to Slate

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    f618626 View commit details
    Browse the repository at this point in the history

  13. Improve docstrings for assemble.py

    @connorjward
    connorjward committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    3a5a567 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Describe assembled matrix row/column spaces

    @connorjward
    connorjward committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    4dfb1e2 View commit details
    Browse the repository at this point in the history

  2. Amend docstring to describe block argument

    @connorjward
    connorjward committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    74db99b View commit details
    Browse the repository at this point in the history