-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointwise adjoint operator #1674
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the PointWiseOp operands
…the PointwiseOpeartor
Superseded by ExternalOperator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update of the deprecated
PointwiseOperator
PR. It is the Firedrake bit of the ExternalOperator concept introduced in UFL.It handles the practical implementation thereof, especially it implements some of the subclasses covered by this concept :
PointexprOperator: Operator defined through an externally defined expression (e.g. lambda expression) passed in. This evaluation of this operator is done by merely evaluate this expression pointwise.
PointsolveOperator: Solve an externally defined algebraic relationship pointwise. For instance one can think to an implicit constitutive law that is part of a given PDE-based model.
PointnetOperator: Represents neural networks. Evaluation is associated to a forward-pass and gradient computation to a gradient of the output wrt inputs. So far, only PyTorch has been covered (it should be straightforward to extend this to TensorFlow).
There are more classes of function that could be derived from the AbstractPointwiseOperator base class.
This PR also cover the implementation of the adjoint capability of pointwise operators enabling to tackle more generally all the PDE-constrained optimization problems containing pointwise operators in the PDE-constraint and/or in the cost function.
Examples of applications cover:
This PR is associated to several other PRs:
UFL: firedrakeproject/ufl#16
Pyadjoint: dolfin-adjoint/pyadjoint#15
TSFC: firedrakeproject/tsfc#201
PyOP2: OP2/PyOP2#579