Skip to content

Fix review findings: constants, deps, and fetch robustness#1

Merged
firede merged 3 commits intomainfrom
fix-review-cleanups
Feb 18, 2026
Merged

Fix review findings: constants, deps, and fetch robustness#1
firede merged 3 commits intomainfrom
fix-review-cleanups

Conversation

@firede
Copy link
Owner

@firede firede commented Feb 18, 2026

Summary

  • replace magic number in markdown sampling with named constant
  • run go mod tidy to correct direct/indirect dependency classification
  • return explicit error on HTTP 4xx/5xx responses instead of treating error pages as success
  • tighten markdown detection to avoid classifying JSON payloads as markdown
  • fix browser header conversion for multi-value Cookie headers (; separator)
  • add regression tests for the above behavior

Validation

  • go test ./...
  • go test -race ./...

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e67eb9890b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@firede firede merged commit 2532b5b into main Feb 18, 2026
1 check passed
@firede firede deleted the fix-review-cleanups branch February 18, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant