Intrigus/fix/ss http resolve archive misc

[intrigus-lgtm]

No description provided.

[ripatel-fd]

Thank you very much for the fixes, these look great. Would you mind adding unit tests reproducing the bugs you've fixed though? If you don't have time to do this, I'm happy to take it over. Just blocking for now to keep myself honest because if I merge this, I'll just forget to add tests later.

[github-actions]

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest mainnet-368528500-perf per slot	0.062978 s	0.063589 s	0.970% ✅
backtest mainnet-368528500-perf snapshot load	2.352 s	2.298 s	-2.296% ✅
backtest mainnet-368528500-perf total elapsed	62.978149 s	63.589483 s	0.971% ✅
firedancer mem usage with mainnet.toml	1014.23 GiB	1014.23 GiB	0.000% ✅

[ripatel-fd]

Suggested change

	if( FD_UNLIKELY( !location ) ) {
	if( FD_UNLIKELY( !location_len ) ) {

[intrigus-lgtm]

Is there a specific reason you prefer this?
When location is not NULL, location_len >= 1 should be guaranteed by line 264.
But of course happy to change this.

[ripatel-fd]

We typically always do "slice empty?" type checks on the length field. It's a more complete solution because often slices with an invalid (but not NULL) base pointer and a zero size length are considered valid

[intrigus-lgtm]

Makes sense!
Should I align

firedancer/src/discof/restore/utils/fd_sshttp.c

Lines 451 to 455 in 8997d39

	if( FD_UNLIKELY( !location ) ) {
	FD_LOG_WARNING(( "no location header in redirect response" ));
	fd_sshttp_cancel( http );
	return FD_SSHTTP_ADVANCE_ERROR;
	}

to this pattern as well?

[ripatel-fd]

yes please

[intrigus-lgtm]

Thank you very much for the fixes, these look great. Would you mind adding unit tests reproducing the bugs you've fixed though? If you don't have time to do this, I'm happy to take it over. Just blocking for now to keep myself honest because if I merge this, I'll just forget to add tests later.

A few of those functions are in static functions.
How should I test those?
I could either make them non-static or test them indirectly.