fix: support both string and object formats for sources parameter #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated firecrawl_search tool schema to accept both string format (["web"]) and object format ([{"type": "web"}])
- Added normalization logic to convert string formats to object format internally
- Updated documentation to show both supported formats
- Fixes HTTP 422 error when using string format for sources parameter
- Maintains backward compatibility with existing implementations
Resolves issue where requests with sources: ["web"] would fail with:
HTTP error 422: {"detail":[{"type":"model_attributes_type","loc":["body","sources",0],"msg":"Input should be a valid dictionary or object to extract fields from","input":"web"}]}
nickscamara
approved these changes
Sep 16, 2025
|
Thank you! @genius-0963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix: Sources Parameter Schema Validation
Problem
The
firecrawl_searchtool had a mismatch between documentation and implementation:sourcesas an array of strings:["web"]sourcesas an array of objects:[{type: "web"}]This caused HTTP 422 errors when using the string format:
{ "error": "HTTP error 422: {\"detail\":[{\"type\":\"model_attributes_type\",\"loc\":[\"body\",\"sources\",0],\"msg\":\"Input should be a valid dictionary or object to extract fields from\",\"input\":\"web\"}]}" }Solution
Changes
sourcesparameter schema infirecrawl_searchtoolTesting
✅ Both formats now work correctly:
sources: ["web"]sources: [{"type": "web"}]Backward Compatibility
This change is fully backward compatible - existing code using either format will continue to work.